lyne7-sc commented on code in PR #22995:
URL: https://github.com/apache/datafusion/pull/22995#discussion_r3442441949
##########
datafusion/datasource-parquet/src/bloom_filter.rs:
##########
@@ -39,7 +39,8 @@ pub(crate) struct BloomFilterStatistics {
/// Value:
/// * [`Sbbf`] (Bloom filter),
/// * Parquet physical [`Type`] needed to evaluate literals against the
filter
- column_sbbf: HashMap<String, (Sbbf, Type)>,
+ /// * Type length from the Parquet column descriptor
+ column_sbbf: HashMap<String, (Sbbf, Type, i32)>,
Review Comment:
Addressed by replacing the tuple with a `ColumnBloomFilter` struct.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
