github-actions[bot] commented on PR #23047: URL: https://github.com/apache/datafusion/pull/23047#issuecomment-4752828804
<!-- semver-check-comment --> Thank you for opening this pull request! Reviewer note: [cargo-semver-checks](https://github.com/obi1kenobi/cargo-semver-checks) reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). <details> <summary>Details</summary> ``` Cloning apache/main Building datafusion-common v54.0.0 (current) Built [ 34.810s] (current) Parsing datafusion-common v54.0.0 (current) Parsed [ 0.060s] (current) Building datafusion-common v54.0.0 (baseline) Built [ 33.490s] (baseline) Parsing datafusion-common v54.0.0 (baseline) Parsed [ 0.061s] (baseline) Checking datafusion-common v54.0.0 -> v54.0.0 (no change; assume patch) Checked [ 0.652s] 223 checks: 222 pass, 1 fail, 0 warn, 30 skip --- failure method_parameter_count_changed: pub method parameter count changed --- Description: A publicly-visible method now takes a different number of parameters, not counting the receiver (self) parameter. ref: https://doc.rust-lang.org/cargo/reference/semver.html#fn-change-arity impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.48.0/src/lints/method_parameter_count_changed.ron Failed in: datafusion_common::FunctionalDependencies::join takes 3 parameters in /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/229699db0dd05312c530e37c144be4e87a6c9d34/datafusion/common/src/functional_dependencies.rs:331, but now takes 4 parameters in /home/runner/work/datafusion/datafusion/datafusion/common/src/functional_dependencies.rs:335 Summary semver requires new major version: 1 major and 0 minor checks failed Finished [ 70.278s] datafusion-common Building datafusion-expr v54.0.0 (current) Built [ 28.425s] (current) Parsing datafusion-expr v54.0.0 (current) Parsed [ 0.076s] (current) Building datafusion-expr v54.0.0 (baseline) Built [ 27.486s] (baseline) Parsing datafusion-expr v54.0.0 (baseline) Parsed [ 0.077s] (baseline) Checking datafusion-expr v54.0.0 -> v54.0.0 (no change; assume patch) Checked [ 1.256s] 223 checks: 222 pass, 1 fail, 0 warn, 30 skip --- failure function_parameter_count_changed: pub fn parameter count changed --- Description: A publicly-visible function now takes a different number of parameters. ref: https://doc.rust-lang.org/cargo/reference/semver.html#fn-change-arity impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.48.0/src/lints/function_parameter_count_changed.ron Failed in: datafusion_expr::logical_plan::builder::build_join_schema now takes 4 parameters instead of 3, in /home/runner/work/datafusion/datafusion/datafusion/expr/src/logical_plan/builder.rs:1689 datafusion_expr::builder::build_join_schema now takes 4 parameters instead of 3, in /home/runner/work/datafusion/datafusion/datafusion/expr/src/logical_plan/builder.rs:1689 datafusion_expr::logical_plan::build_join_schema now takes 4 parameters instead of 3, in /home/runner/work/datafusion/datafusion/datafusion/expr/src/logical_plan/builder.rs:1689 datafusion_expr::build_join_schema now takes 4 parameters instead of 3, in /home/runner/work/datafusion/datafusion/datafusion/expr/src/logical_plan/builder.rs:1689 Summary semver requires new major version: 1 major and 0 minor checks failed Finished [ 58.797s] datafusion-expr Building datafusion-optimizer v54.0.0 (current) Built [ 26.805s] (current) Parsing datafusion-optimizer v54.0.0 (current) Parsed [ 0.029s] (current) Building datafusion-optimizer v54.0.0 (baseline) Built [ 26.178s] (baseline) Parsing datafusion-optimizer v54.0.0 (baseline) Parsed [ 0.031s] (baseline) Checking datafusion-optimizer v54.0.0 -> v54.0.0 (no change; assume patch) Checked [ 0.182s] 223 checks: 223 pass, 30 skip Summary no semver update required Finished [ 54.386s] datafusion-optimizer Building datafusion-sql v54.0.0 (current) Built [ 41.019s] (current) Parsing datafusion-sql v54.0.0 (current) Parsed [ 0.031s] (current) Building datafusion-sql v54.0.0 (baseline) Built [ 42.120s] (baseline) Parsing datafusion-sql v54.0.0 (baseline) Parsed [ 0.033s] (baseline) Checking datafusion-sql v54.0.0 -> v54.0.0 (no change; assume patch) Checked [ 0.214s] 223 checks: 223 pass, 30 skip Summary no semver update required Finished [ 84.351s] datafusion-sql ``` </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
