2010YOUY01 commented on code in PR #23053:
URL: https://github.com/apache/datafusion/pull/23053#discussion_r3445611472
##########
datafusion/functions-aggregate/src/approx_distinct.rs:
##########
@@ -829,12 +829,104 @@ fn is_hll_groups_type(data_type: &DataType) -> bool {
#[cfg(test)]
mod tests {
use super::*;
- use arrow::array::{AsArray, Int64Array, StringViewArray};
use std::hash::BuildHasher;
- use std::sync::Arc;
- // A string longer than the 12-byte inline limit
- const LONG: &str = "this string is definitely longer than twelve bytes";
+ #[cfg(not(feature = "force_hash_collisions"))]
Review Comment:
I think it's a good idea. Forcing hash collisions is only applicable to
e2e/sql tests I think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
