0lai0 opened a new pull request, #4697:
URL: https://github.com/apache/datafusion-comet/pull/4697
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases. You can
link an issue to this PR using the GitHub syntax. For example `Closes #123`
indicates that this PR will close issue #123.
-->
Closes #4684.
## Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in
the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your
changes and offer better suggestions for fixes.
-->
Comet's `ElementAt` serde only accepted `ArrayType` input. Spark supports
both `ArrayType` and `MapType`, so map lookups via `element_at(map, key)` and
`try_element_at(map, key)` always fell back to Spark.
## What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is
sometimes worth providing a summary of the individual changes in this PR.
-->
- `CometElementAt.getSupportLevel`: accepts MapType in addition to
ArrayType.
- `CometElementAt.convert`: dispatches on input type, MapType routes to
native map_extract (same path used by GetMapValue); ArrayType is unchanged.
- Updates `expressions.md`, `array_funcs.md`, and `map_funcs.md` to
reflect the new support.
## How are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are
they covered by existing tests)?
-->
- New SQL test file `map/element_at_map.sql`: covers key found, key not
found (→ NULL), null map, null key, integer key type, key type coercion, and
literal map arguments.
- Updated `array/try_element_at.sql`: the map test case now verifies native
execution rather than just comparing Spark answers.
- Note: Spark's `ElementAt` for `MapType` does not use `failOnError`,
key-not-found always returns NULL regardless of ANSI mode, so no ANSI fallback
is needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
