huan233usc opened a new pull request, #23060:
URL: https://github.com/apache/datafusion/pull/23060

   ## Which issue does this PR close?
   
   Follow-up to #22839 (stdin support in `datafusion-cli`), addressing 
post-merge review feedback from @alamb. No separate issue.
   
   ## Rationale for this change
   
   In the review of #22839, @alamb noted that the `StdinUtils::get_or_create` 
doc comment was technically imprecise:
   
   > technically I would say this buffers stdin on construction, not first use.
   
   The `stdin://` store reads and buffers all of standard input eagerly when 
the store is constructed (`object_store` → `read_to_end` → 
`in_memory_object_store`), not lazily on first use of the store. The doc 
comment said "on first use", which suggests lazy buffering.
   
   ## What changes are included in this PR?
   
   Reword the first sentence of the `get_or_create` doc comment to say the 
store buffers all of standard input "when the store is first constructed" 
instead of "on first use". Doc-comment only; no behavior change.
   
   ## Are these changes tested?
   
   No code change — documentation only. Existing tests in 
`object_storage/stdin.rs` are unaffected.
   
   ## Are there any user-facing changes?
   
   No.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to