alamb opened a new issue, #23080: URL: https://github.com/apache/datafusion/issues/23080
Follow on to working on https://github.com/apache/datafusion/pull/23029 The [API health policy deprecation guidelines](https://datafusion.apache.org/contributor-guide/api-health.html#deprecation-guidelines) say deprecated methods remain for > 6 major versions or 6 months, whichever is longer Thus, as of now when we are working on 55.0.0. anything deprecated in 49.0.0 or earlier clears the six-major-version side of the policy Here is a list of possible candidate code we can remove. I suggest creating individual PRs for each item (or similar ones) to speed up review and merge # Deprecated API Removal Candidates ## Obvious Candidates - [`UnionExec::new`](https://github.com/apache/datafusion/blob/main/datafusion/physical-plan/src/union.rs#L114), deprecated in 44.0.0. Replacement: `UnionExec::try_new`. - [`DFParser::new`](https://github.com/apache/datafusion/blob/main/datafusion/sql/src/parser.rs#L507) and [`DFParser::new_with_dialect`](https://github.com/apache/datafusion/blob/main/datafusion/sql/src/parser.rs#L512), deprecated in 46.0.0. Replacement: `DFParserBuilder`. - [`datafusion_sql::{ResolvedTableReference, TableReference}` re-exports](https://github.com/apache/datafusion/blob/main/datafusion/sql/src/lib.rs#L60), deprecated in 46.0.0. Replacement: import from `datafusion_common`. - [`ScalarValue::raw_data`](https://github.com/apache/datafusion/blob/main/datafusion/common/src/scalar/mod.rs#L3926), deprecated in 46.0.0. Replacement: `to_array`. - [`Signature::get_possible_types`](https://github.com/apache/datafusion/blob/main/datafusion/expr-common/src/signature.rs#L883), deprecated in 46.0.0. Replacement: `get_example_types`. - [`RowIndex`](https://github.com/apache/datafusion/blob/main/datafusion/physical-plan/src/sorts/index.rs#L53), deprecated in 46.0.0 and appears unused outside its definition. - [`ViewTable::try_new`](https://github.com/apache/datafusion/blob/main/datafusion/catalog/src/view.rs#L62), deprecated in 47.0.0. Replacement: `ViewTable::new`. - [`DFSchema::check_arrow_schema_type_compatible`](https://github.com/apache/datafusion/blob/main/datafusion/common/src/dfschema.rs#L603), deprecated in 47.0.0 and appears definition-only. - [`coerce_file_schema_to_view_type`](https://github.com/apache/datafusion/blob/main/datafusion/datasource-parquet/src/schema_coercion.rs#L422) and [`coerce_file_schema_to_string_type`](https://github.com/apache/datafusion/blob/main/datafusion/datasource-parquet/src/schema_coercion.rs#L475), deprecated in 47.0.0. Replacement: `apply_file_schema_type_coercions`. - [`create_writer`](https://github.com/apache/datafusion/blob/main/datafusion/datasource/src/write/mod.rs#L85), deprecated in 48.0.0 and appears definition-only. Replacement: `ObjectWriterBuilder::new(...)`. - [`Filter::try_new_with_having`](https://github.com/apache/datafusion/blob/main/datafusion/expr/src/logical_plan/plan.rs#L2652), deprecated in 48.0.0 and appears definition-only. Replacement: `try_new`. ## More Invasive Candidates - [`DiskManagerConfig`](https://github.com/apache/datafusion/blob/main/datafusion/execution/src/disk_manager.rs#L155), [`DiskManager::try_new`](https://github.com/apache/datafusion/blob/main/datafusion/execution/src/disk_manager.rs#L242), and [`RuntimeEnvBuilder::with_disk_manager`](https://github.com/apache/datafusion/blob/main/datafusion/execution/src/runtime_env.rs#L375), deprecated in 48.0.0. Eligible, but removal touches runtime configuration plumbing. - [`Expr::Wildcard`](https://github.com/apache/datafusion/blob/main/datafusion/expr/src/expr.rs#L397), deprecated in 46.0.0. Eligible, but higher risk because it is an enum variant and may affect downstream pattern matches. - Old Substrait variation constants in [`variation_const.rs`](https://github.com/apache/datafusion/blob/main/datafusion/substrait/src/variation_const.rs), deprecated in 41.0.0 to 43.0.0. Eligible, but currently used internally to consume older Substrait encodings, so removal may be a compatibility decision rather than mechanical cleanup. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
