alamb commented on code in PR #23030:
URL: https://github.com/apache/datafusion/pull/23030#discussion_r3452371244
##########
datafusion/proto/tests/cases/roundtrip_logical_plan.rs:
##########
@@ -3509,3 +3509,97 @@ async fn roundtrip_join_null_equality() -> Result<()> {
Ok(())
}
+
+// Single column, single split point range partitioning
+#[tokio::test]
+async fn roundtrip_range_partitioning_single_col() -> Result<()> {
+ let schema = Arc::new(Schema::new(vec![
+ Field::new("id", DataType::Int32, false),
+ Field::new("name", DataType::Utf8, true),
+ ]));
+ let table =
Arc::new(datafusion::datasource::empty::EmptyTable::new(Arc::clone(
+ &schema,
+ )));
+
+ let ctx = SessionContext::new();
+ ctx.register_table("empty", table)?;
+
+ let scan_plan = ctx.table("empty").await?.into_optimized_plan()?;
+ let plan = LogicalPlan::Repartition(Repartition {
+ input: Arc::new(scan_plan),
+ partitioning_scheme: Partitioning::Range(RangePartitioning::try_new(
+ vec![col("id").sort(true, true)],
+ vec![SplitPoint::new(vec![ScalarValue::Int32(Some(10))])],
+ )?),
+ });
+ let bytes = logical_plan_to_bytes(&plan)?;
+ let logical_round_trip = logical_plan_from_bytes(&bytes, &ctx.task_ctx())?;
+ assert_eq!(format!("{plan:?}"), format!("{logical_round_trip:?}"));
+ Ok(())
+}
+
+// Multi-column compound key with multiple split points for range partitioning
+#[tokio::test]
+async fn roundtrip_range_partitioning_multi_col() -> Result<()> {
+ let schema = Arc::new(Schema::new(vec![
+ Field::new("ts", DataType::Int64, false),
+ Field::new("region", DataType::Utf8, false),
+ ]));
+ let table =
Arc::new(datafusion::datasource::empty::EmptyTable::new(Arc::clone(
Review Comment:
as a minor nit, `datafusion::datasource::empty::EmptyTable:` is pretty hard
on the eyes. It would be nicer if there was a single `use
datafusion::datasource::empty::EmptyTable;` at the top and then used down here
(and the other tests)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
