saadtajwar commented on code in PR #23094:
URL: https://github.com/apache/datafusion/pull/23094#discussion_r3455971811
##########
datafusion/proto/src/physical_plan/to_proto.rs:
##########
@@ -380,6 +380,15 @@ pub fn serialize_partitioning(
serialize_range_partitioning(range, codec, proto_converter)?,
)),
},
+ Partitioning::DynamicRange(_) => {
+ // Proto plumbing for DynamicRange is intentionally not
+ // implemented in the variant-introduction PR and will be
+ // added incrementally. See
+ // <https://github.com/apache/datafusion/issues/22395>.
+ return not_impl_err!(
+ "Serialization of DynamicRange partitioning is not implemented"
+ );
+ }
Review Comment:
Following the discussion in the GH issue & PR comments - I don't have a ton
of feedback, as I'm still trying to understand the broader context (and
Datafusion in general haha!) but if we get alignment here I'm happy to help out
with this piece specifically :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
