haohuaijin commented on code in PR #23078:
URL: https://github.com/apache/datafusion/pull/23078#discussion_r3456575915
##########
datafusion/physical-plan/src/joins/hash_join/exec.rs:
##########
@@ -6610,6 +6611,63 @@ mod tests {
Ok(())
}
+ #[test]
+ fn test_swap_inputs_clears_dynamic_filter() -> Result<()> {
Review Comment:
yes, we directly call the `swap_inputs()` after the dynamic filter pushdown
rule(by add a new physical optmizer rule via
`SessionStateBuilder::with_physical_optimizer_rule`), it will not trigger by
the datafusion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]