Myx778 commented on PR #4105: URL: https://github.com/apache/datafusion-comet/pull/4105#issuecomment-4776362503
Hi @andygrove and @mbutrovich, Hope you both are doing well! I just rebased onto the latest main again to resolve fresh merge conflicts (the branch had fallen 82 commits behind since the previous rebase). A note on one substantive merge decision worth flagging: - main now contains a `CometLevenshtein extends CometCodegenDispatch[Levenshtein]` (JVM codegen dispatch path). I replaced it with this PR's native implementation, since the two would otherwise collide and a native path is what this PR was originally designed to deliver. Happy to revisit this if you'd prefer a different approach — for instance, an opt-in config flag that selects between native vs codegen-dispatch, similar to the `CometCaseConversionBase` pattern. The PR has been through ~5 review rounds since April and I've tried to address all substantive feedback. The branch is mergeable now and I've kept the commit history clean. Whenever either of you has a moment, would you be able to take another look, or kick off CI so we can confirm everything is green? No urgency at all — I really appreciate the time you've already put into reviewing this. Thanks so much for your guidance throughout! Best regards, Yuxin -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
