Dandandan commented on code in PR #23107:
URL: https://github.com/apache/datafusion/pull/23107#discussion_r3457920138
##########
datafusion/physical-plan/src/sorts/merge.rs:
##########
@@ -512,22 +512,33 @@ impl<C: CursorValues> SortPreservingMergeStream<C> {
let mut cmp_node = self.lt_leaf_node_index(winner);
// Traverse up the tree to adjust comparisons until reaching the root.
- while cmp_node != 0 {
+ while cmp_node > 1 {
Review Comment:
Optimization 2: repeat longer runs with `cmp_node > 1`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
