alamb commented on code in PR #11806:
URL: https://github.com/apache/datafusion/pull/11806#discussion_r1704502590
##########
datafusion/physical-plan/src/joins/hash_join.rs:
##########
@@ -2029,12 +2031,21 @@ mod tests {
assert_eq!(columns, vec!["a1", "b2", "c1", "a1", "b2", "c2"]);
- // expected joined records = 3
- // in case batch_size is 1 - additional empty batch for remaining 3-2
row
- let mut expected_batch_count = div_ceil(3, batch_size);
- if batch_size == 1 {
- expected_batch_count += 1;
- }
+ let expected_batch_count = if cfg!(not(feature =
"force_hash_collisions")) {
+ // Expected number of hash table matches = 3
+ // in case batch_size is 1 - additional empty batch for remaining
3-2 row
+ let mut expected_batch_count = div_ceil(3, batch_size);
+ if batch_size == 1 {
+ expected_batch_count += 1;
+ }
+ expected_batch_count
+ } else {
+ // With hash collisions enabled, all records will match each other
+ // and filtered later.
+ // Expected number of matches = 9
Review Comment:
Likewise this seems somewhat redundant (and same below)
```suggestion
```
##########
datafusion/physical-plan/src/joins/hash_join.rs:
##########
@@ -1964,12 +1960,21 @@ mod tests {
assert_eq!(columns, vec!["a1", "b2", "c1", "a1", "b2", "c2"]);
- // expected joined records = 3
- // in case batch_size is 1 - additional empty batch for remaining 3-2
row
- let mut expected_batch_count = div_ceil(3, batch_size);
- if batch_size == 1 {
- expected_batch_count += 1;
- }
+ let expected_batch_count = if cfg!(not(feature =
"force_hash_collisions")) {
+ // Expected number of hash table matches = 3
+ // in case batch_size is 1 - additional empty batch for remaining
3-2 row
+ let mut expected_batch_count = div_ceil(3, batch_size);
+ if batch_size == 1 {
+ expected_batch_count += 1;
+ }
+ expected_batch_count
+ } else {
+ // With hash collisions enabled, all records will match each other
+ // and filtered later.
+ // Expected number of matches = 9
Review Comment:
nit I think the comment is redundant with the assert right below it
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
