2010YOUY01 commented on PR #23055: URL: https://github.com/apache/datafusion/pull/23055#issuecomment-4777752966
All comments have been addressed, thank you for the careful reviews! @alamb @Rachelint > I found this code really easy to follow and understand. While it is complicated, I think it much more closely mirrors the complexity of the problem being solved now and setting up the control flow logic in this way means we will be in a much better place to improve the performance / featuers going forward I only figured this out very recently. The split-stream approach is somewhat counterintuitive: it does introduce a lot of duplicated code, but it can make the code easier to work with. The key idea, I think, is problem decomposition. If we can break a large problem into smaller subproblems, we can tackle each of them individually. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
