github-actions[bot] commented on PR #23125:
URL: https://github.com/apache/datafusion/pull/23125#issuecomment-4779615122

   <!-- semver-check-comment -->
   Thank you for opening this pull request!
   
   Reviewer note: 
[cargo-semver-checks](https://github.com/obi1kenobi/cargo-semver-checks) 
reported the current version number is not SemVer-compatible with the changes 
in this pull request (compared against the base branch).
   
   <details>
   <summary>Details</summary>
   
   ```
        Cloning apache/main
       Building datafusion-datasource v54.0.0 (current)
          Built [  43.167s] (current)
        Parsing datafusion-datasource v54.0.0 (current)
         Parsed [   0.032s] (current)
       Building datafusion-datasource v54.0.0 (baseline)
          Built [  38.269s] (baseline)
        Parsing datafusion-datasource v54.0.0 (baseline)
         Parsed [   0.031s] (baseline)
       Checking datafusion-datasource v54.0.0 -> v54.0.0 (no change; assume 
patch)
        Checked [   0.251s] 223 checks: 223 pass, 30 skip
        Summary no semver update required
       Finished [  84.160s] datafusion-datasource
       Building datafusion-datasource-parquet v54.0.0 (current)
          Built [  43.835s] (current)
        Parsing datafusion-datasource-parquet v54.0.0 (current)
         Parsed [   0.031s] (current)
       Building datafusion-datasource-parquet v54.0.0 (baseline)
          Built [  43.300s] (baseline)
        Parsing datafusion-datasource-parquet v54.0.0 (baseline)
         Parsed [   0.030s] (baseline)
       Checking datafusion-datasource-parquet v54.0.0 -> v54.0.0 (no change; 
assume patch)
        Checked [   0.159s] 223 checks: 223 pass, 30 skip
        Summary no semver update required
       Finished [  88.772s] datafusion-datasource-parquet
       Building datafusion-physical-expr-adapter v54.0.0 (current)
          Built [  30.821s] (current)
        Parsing datafusion-physical-expr-adapter v54.0.0 (current)
         Parsed [   0.009s] (current)
       Building datafusion-physical-expr-adapter v54.0.0 (baseline)
          Built [  31.202s] (baseline)
        Parsing datafusion-physical-expr-adapter v54.0.0 (baseline)
         Parsed [   0.010s] (baseline)
       Checking datafusion-physical-expr-adapter v54.0.0 -> v54.0.0 (no change; 
assume patch)
        Checked [   0.081s] 223 checks: 222 pass, 1 fail, 0 warn, 30 skip
   
   --- failure function_missing: pub fn removed or renamed ---
   
   Description:
   A publicly-visible function cannot be imported by its prior path. A `pub 
use` may have been removed, or the function itself may have been renamed or 
removed entirely.
           ref: 
https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
          impl: 
https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.48.0/src/lints/function_missing.ron
   
   Failed in:
     function 
datafusion_physical_expr_adapter::schema_rewriter::rewrite_input_file_name_in_projection,
 previously in file 
/home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/b8edfd7f8620e038f0b2fa87d3962dfbd0537fcd/datafusion/physical-expr-adapter/src/schema_rewriter.rs:203
     function 
datafusion_physical_expr_adapter::schema_rewriter::rewrite_file_row_index_projection,
 previously in file 
/home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/b8edfd7f8620e038f0b2fa87d3962dfbd0537fcd/datafusion/physical-expr-adapter/src/schema_rewriter.rs:169
     function 
datafusion_physical_expr_adapter::rewrite_file_row_index_projection, previously 
in file 
/home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/b8edfd7f8620e038f0b2fa87d3962dfbd0537fcd/datafusion/physical-expr-adapter/src/schema_rewriter.rs:169
     function 
datafusion_physical_expr_adapter::schema_rewriter::rewrite_file_row_index_expr, 
previously in file 
/home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/b8edfd7f8620e038f0b2fa87d3962dfbd0537fcd/datafusion/physical-expr-adapter/src/schema_rewriter.rs:142
     function datafusion_physical_expr_adapter::rewrite_file_row_index_expr, 
previously in file 
/home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/b8edfd7f8620e038f0b2fa87d3962dfbd0537fcd/datafusion/physical-expr-adapter/src/schema_rewriter.rs:142
     function 
datafusion_physical_expr_adapter::schema_rewriter::expr_references_scalar_udf, 
previously in file 
/home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/b8edfd7f8620e038f0b2fa87d3962dfbd0537fcd/datafusion/physical-expr-adapter/src/schema_rewriter.rs:93
     function datafusion_physical_expr_adapter::expr_references_scalar_udf, 
previously in file 
/home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/b8edfd7f8620e038f0b2fa87d3962dfbd0537fcd/datafusion/physical-expr-adapter/src/schema_rewriter.rs:93
   
        Summary semver requires new major version: 1 major and 0 minor checks 
failed
       Finished [  63.023s] datafusion-physical-expr-adapter
   ```
   
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to