Dodothereal commented on PR #23139: URL: https://github.com/apache/datafusion/pull/23139#issuecomment-4784474673
@alamb (and any other reviewer) — another #23080 partial removal: `DiskManagerConfig` and `DiskManager::try_new` from the execution crate (deprecated since 48.0.0, replaced by `DiskManagerBuilder`). 75-line deletion in `disk_manager.rs` + callsite updates in `runtime_env.rs`. All 35 CI checks (cargo test amd64/macos-aarch64, clippy, rustfmt, license-header, semver, MSRV, sqllogictest, codeql) are green. Happy to address any feedback. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
