Dodothereal opened a new pull request, #23143: URL: https://github.com/apache/datafusion/pull/23143
Fixes #23080 ## Summary Removes the deprecated `RowIndex` struct from `datafusion-physical-plan`. The whole `datafusion/physical-plan/src/sorts/index.rs` file (61 lines, just the doc-block + struct) is deleted because it was never declared in `sorts/mod.rs` and never re-exported via `pub use` — it was a dead file already. A grep across the workspace confirms zero remaining callers even of the doc comment's identifier, and zero public re-exports. The 6-major-version grace period cited by the API-health policy is past due (deprecated in 46.0.0, we are now on 55.x). ## Test plan - `git grep -nE '\bRowIndex\b'` returns no matches in source or docs (false-positives filtered: `FileRowIndexFunc` is a separate, undeprecated symbol). - `sorts/mod.rs` does not declare `mod index;`, so removing the on-disk file is sufficient — no `mod` cleanup needed. - The `datafusion-physical-plan` crate still builds cleanly across all other sort modules. AI assistance: drafted with the help of an Anthropic coding assistant. Diff was reviewed line by line before submission, and the change was verified independently. Signed-off-by: Dodothereal <[email protected]> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
