tschwarzinger opened a new pull request, #23157:
URL: https://github.com/apache/datafusion/pull/23157

   ## Which issue does this PR close?
   
   We had a `LogicalPlan` extension for which it was expensive to print the 
debugging information and which occurred multiple times in each query.  Because 
the old code always created a string with the debugging information even in the 
success path, this overhead accumulated. I think this was exaggerated by our 
huge debug info but I thought we could avoid this.
   
   Are there any existing benchmarks with respect to extension planning? At 
least `sql_planner` and `sql_planner_extended` don't seem to have one on first 
sight.
   
   ## Rationale for this change
   
   Avoid printing debug info if it's not needed
   
   ## What changes are included in this PR?
   
   - Swap an `&str` to a closure that computes the string on-demand. 
   
   ## Are these changes tested?
   
   Existing tests
   
   ## Are there any user-facing changes?
   
   No


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to