github-actions[bot] commented on PR #23170: URL: https://github.com/apache/datafusion/pull/23170#issuecomment-4794099685
<!-- semver-check-comment --> Thank you for opening this pull request! Reviewer note: [cargo-semver-checks](https://github.com/obi1kenobi/cargo-semver-checks) reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). <details> <summary>Details</summary> ``` Cloning apache/main Building datafusion-execution v54.0.0 (current) Built [ 34.808s] (current) Parsing datafusion-execution v54.0.0 (current) Parsed [ 0.024s] (current) Building datafusion-execution v54.0.0 (baseline) Built [ 28.732s] (baseline) Parsing datafusion-execution v54.0.0 (baseline) Parsed [ 0.025s] (baseline) Checking datafusion-execution v54.0.0 -> v54.0.0 (no change; assume patch) Checked [ 0.228s] 223 checks: 221 pass, 2 fail, 0 warn, 30 skip --- failure enum_variant_added: enum variant added on exhaustive enum --- Description: A publicly-visible enum without #[non_exhaustive] has a new variant. ref: https://doc.rust-lang.org/cargo/reference/semver.html#enum-variant-new impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.48.0/src/lints/enum_variant_added.ron Failed in: variant DiskManagerMode:Custom in /home/runner/work/datafusion/datafusion/datafusion/execution/src/disk_manager.rs:135 --- failure inherent_method_missing: pub method removed or renamed --- Description: A publicly-visible method or associated fn is no longer available under its prior name. It may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.48.0/src/lints/inherent_method_missing.ron Failed in: RefCountedTempFile::update_disk_usage, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/da9c36f68aa514eb3a5b072f3ce858e127317294/datafusion/execution/src/disk_manager.rs:409 RefCountedTempFile::current_disk_usage, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/da9c36f68aa514eb3a5b072f3ce858e127317294/datafusion/execution/src/disk_manager.rs:457 Summary semver requires new major version: 2 major and 0 minor checks failed Finished [ 64.959s] datafusion-execution Building datafusion-physical-plan v54.0.0 (current) Built [ 35.371s] (current) Parsing datafusion-physical-plan v54.0.0 (current) Parsed [ 0.130s] (current) Building datafusion-physical-plan v54.0.0 (baseline) Built [ 35.386s] (baseline) Parsing datafusion-physical-plan v54.0.0 (baseline) Parsed [ 0.128s] (baseline) Checking datafusion-physical-plan v54.0.0 -> v54.0.0 (no change; assume patch) Checked [ 0.611s] 223 checks: 222 pass, 1 fail, 0 warn, 30 skip --- failure function_missing: pub fn removed or renamed --- Description: A publicly-visible function cannot be imported by its prior path. A `pub use` may have been removed, or the function itself may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.48.0/src/lints/function_missing.ron Failed in: function datafusion_physical_plan::spill::spill_record_batch_by_size, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/da9c36f68aa514eb3a5b072f3ce858e127317294/datafusion/physical-plan/src/spill/mod.rs:255 Summary semver requires new major version: 1 major and 0 minor checks failed Finished [ 72.633s] datafusion-physical-plan ``` </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
