peterxcli commented on code in PR #4716:
URL: https://github.com/apache/datafusion-comet/pull/4716#discussion_r3475407851
##########
spark/src/test/resources/sql-tests/expressions/array/array_prepend.sql:
##########
Review Comment:
I notice this sql would fail on comet with error sth like:
"INVALID_INDEX_OF_ZERO", and the root cause is because comet's array_insert
execution didnt Spark’s short-circuit evaluation.
````sql
statement
CREATE TABLE test_array_prepend(
arr ARRAY<INT>,
idx INT
) USING parquet
statement
INSERT INTO test_array_prepend VALUES
(NULL, 0),
(array(1), 1)
query
SELECT array_prepend(arr, element_at(array(9), idx))
FROM test_array_prepend
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
