SubhamSinghal commented on code in PR #23096:
URL: https://github.com/apache/datafusion/pull/23096#discussion_r3475700743
##########
datafusion/physical-plan/src/topk/mod.rs:
##########
@@ -1845,4 +2060,157 @@ mod tests {
Ok(())
}
+
+ /// Builds a `(pk Int32, val Int32)` schema and a `PartitionedTopK`
+ /// partitioned by `pk` with order `val ASC`. Helper for the
+ /// `PartitionedTopK` tests below.
+ fn build_partitioned_topk(k: usize) -> Result<(Arc<Schema>,
PartitionedTopK)> {
Review Comment:
Added UT covering null first, null last and sort desc direction
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
