JasonLi-cn commented on PR #11758: URL: https://github.com/apache/datafusion/pull/11758#issuecomment-2270183214
> Thank you @JasonLi-cn > > I wonder if we have tested the performance of this branch? I worry that the incremental output generation will result in a copying the values multiple times (as each `emit_to` will effectively copy the remaining elements "down" > > If this turns out to be a large performance overhead, then I think we could look into updating the accumulators to remember where they have emitted to or something (or maybe add a `EmitNext` or something that could handle remebering the offset 🤔 Thank you @alamb . I'll run the benchmark of aggregate. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
