andygrove commented on issue #3386: URL: https://github.com/apache/datafusion-comet/issues/3386#issuecomment-4802005752
Closing as resolved. Comet now executes this expression within the native pipeline by routing it through the JVM codegen dispatcher (`spark.comet.exec.scalaUDF.codegen.enabled`, enabled by default), which Janino-compiles Spark's own code generation into a per-batch Arrow kernel. The expression no longer falls back to Spark, so a dedicated native (Rust) implementation is not required for coverage. We can revisit a native implementation in the future where there is a proven performance benefit. Please reopen or file a follow-up if you hit a correctness or performance gap with the current path. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
