comphead commented on code in PR #4733:
URL: https://github.com/apache/datafusion-comet/pull/4733#discussion_r3477725942
##########
spark/src/main/scala/org/apache/spark/sql/comet/CometMetricNode.scala:
##########
@@ -259,12 +273,28 @@ object CometMetricNode {
SQLMetrics.createMetric(sc, "Rows filtered out by parquet page index"),
"page_index_rows_matched" ->
SQLMetrics.createMetric(sc, "Rows passed through the parquet page
index"),
+ "page_index_pages_pruned" ->
+ SQLMetrics.createMetric(sc, "Pages filtered out by parquet page
index"),
+ "page_index_pages_matched" ->
+ SQLMetrics.createMetric(sc, "Pages passed through the parquet page
index"),
"page_index_eval_time" ->
SQLMetrics.createNanoTimingMetric(sc, "Time spent evaluating parquet
page index filters"),
"metadata_load_time" ->
SQLMetrics.createNanoTimingMetric(
sc,
- "Time spent reading and parsing metadata from the footer"))
+ "Total time spent reading and parsing metadata from the footer"),
+ "predicate_cache_inner_records" ->
+ SQLMetrics.createMetric(
+ sc,
+ "Predicate cache: rows physically read and decoded from the Parquet
file (cache misses)"),
+ "predicate_cache_records" ->
+ SQLMetrics.createMetric(
+ sc,
+ "Predicate cache: records read from the cache (reused after
predicate evaluation)"),
+ "scan_efficiency_ratio_total" ->
+ SQLMetrics.createSizeMetric(
+ sc,
+ "Total file size, denominator of scan_efficiency_ratio =
bytes_scanned / total_file_size"))
Review Comment:
maybe we can rephrase it? unlike to other metrics this one sounds not very
clear
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
