comphead commented on PR #23195: URL: https://github.com/apache/datafusion/pull/23195#issuecomment-4804849009
the benchmark is confusing, the same metric from 2 different runs, reports ``` array_remove_n_int64/remove/list size: 500, num_rows: 10000 1.00 9.3±0.24ms ? ?/sec 1.83 17.0±0.26ms ? ?/sec and then array_remove_n_int64/remove/list size: 500, num_rows: 10000 1.85 16.6±0.15ms ? ?/sec 1.00 9.0±0.13ms ? ?/sec ``` I'll check again my local benchmarks, if its reported as faster I'll follow local recommendations, however even now the PR brings some purpose in terms of unification -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
