XiangpengHao commented on code in PR #11796:
URL: https://github.com/apache/datafusion/pull/11796#discussion_r1705034145
##########
datafusion/expr/src/type_coercion/binary.rs:
##########
@@ -890,15 +890,22 @@ fn dictionary_coercion(
/// 2. Data type of the other side should be able to cast to string type
fn string_concat_coercion(lhs_type: &DataType, rhs_type: &DataType) ->
Option<DataType> {
use arrow::datatypes::DataType::*;
- string_coercion(lhs_type, rhs_type).or(match (lhs_type, rhs_type) {
- (Utf8, from_type) | (from_type, Utf8) => {
- string_concat_internal_coercion(from_type, &Utf8)
- }
- (LargeUtf8, from_type) | (from_type, LargeUtf8) => {
- string_concat_internal_coercion(from_type, &LargeUtf8)
+ match (lhs_type, rhs_type) {
+ // If Utf8View is in any side, we coerce to Utf8.
Review Comment:
Agree, similar to this policy:
https://github.com/apache/datafusion/blob/b50887f00a1e6009d5ee01c9194ac5ea3269ed8b/datafusion/expr/src/type_coercion/binary.rs#L935-L947
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
