iffyio commented on code in PR #2251:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/2251#discussion_r3490896679
##########
src/parser/mod.rs:
##########
@@ -5238,6 +5238,12 @@ impl<'a> Parser<'a> {
self.parse_create_snapshot_table().map(Into::into)
} else if self.peek_keywords(&[Keyword::TEXT, Keyword::SEARCH]) {
self.parse_create_text_search().map(Into::into)
+ } else if self.peek_keywords(&[Keyword::UNLOGGED, Keyword::TABLE]) {
+ self.expect_keywords(&[Keyword::UNLOGGED, Keyword::TABLE])?;
+ let mut create_table = self
+ .parse_create_table(or_replace, temporary, global, transient,
volatile, multiset)?;
Review Comment:
can this instead use the same pattern as temporary/volatile etc, that we
flag the bool beforehand, so that we reuse the same call to parse_create_table?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
