lyne7-sc commented on code in PR #23148:
URL: https://github.com/apache/datafusion/pull/23148#discussion_r3492931195
##########
datafusion/ffi/src/udf/mod.rs:
##########
@@ -83,6 +83,9 @@ pub struct FFI_ScalarUDF {
/// See [`ScalarUDFImpl`] for details on short_circuits
pub short_circuits: bool,
+ /// See [`ScalarUDFImpl`] for details on is_strict.
+ pub is_strict: bool,
Review Comment:
Thanks @kosiew for the review, that makes sense. I don’t think the current
ABI can distinguish older `FFI_ScalarUDF` structs from newer ones that include
this metadata, so I updated the PR to make the FFI path conservative for now.
`is_strict` is no longer propagated through `FFI_ScalarUDF`, and
`ForeignScalarUDF` now falls back to the `ScalarUDFImpl` default of `false`.
Native/local UDFs still use strictness metadata, but foreign UDFs won’t
participate in the new outer-join rewrite for now.
I agree we can revisit FFI strictness propagation later with a dedicated
ABI/versioning mechanism.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
