alamb commented on code in PR #20924:
URL: https://github.com/apache/datafusion/pull/20924#discussion_r3493715227
##########
datafusion/physical-plan/src/repartition/mod.rs:
##########
@@ -2953,4 +2969,47 @@ mod test {
let exec = Arc::new(exec);
Arc::new(TestMemoryExec::update_cache(&exec))
}
+
+ /// preserve_order repartition should not double-count
+ /// output rows.
+ #[tokio::test]
Review Comment:
I verified this test covers the new code
```
cargo test -p datafusion-physical-plan -- --nocapture
```
This fails without the code change
```
thread
'repartition::test::test_preserve_order_output_rows_not_double_counted'
panicked at datafusion/physical-plan/src/repartition/mod.rs:2991:9:
assertion `left == right` failed: metrics output_rows (8) should match
actual rows collected (4), not double-count
left: 8
right: 4
Verification
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
