comphead commented on code in PR #4758:
URL: https://github.com/apache/datafusion-comet/pull/4758#discussion_r3494292900
##########
spark/src/main/scala/org/apache/comet/rules/CometScanRule.scala:
##########
@@ -88,12 +88,12 @@ case class CometScanRule(session: SparkSession)
case _ => false
}
- def hasMetadataCol(plan: SparkPlan): Boolean = {
- plan.expressions.exists(_.exists {
+ def hasMetadataCol(plan: SparkPlan) = {
Review Comment:
looks method doesn't return bool anymore? the name should reflect it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
