github-actions[bot] commented on PR #23063: URL: https://github.com/apache/datafusion/pull/23063#issuecomment-4842550245
<!-- semver-check-comment --> Thank you for opening this pull request! Reviewer note: [cargo-semver-checks](https://github.com/obi1kenobi/cargo-semver-checks) reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). <details> <summary>Details</summary> ``` Cloning apache/main Building datafusion v54.0.0 (current) Built [ 98.163s] (current) Parsing datafusion v54.0.0 (current) Parsed [ 0.034s] (current) Building datafusion v54.0.0 (baseline) Built [ 97.886s] (baseline) Parsing datafusion v54.0.0 (baseline) Parsed [ 0.035s] (baseline) Checking datafusion v54.0.0 -> v54.0.0 (no change; assume patch) Checked [ 0.567s] 223 checks: 223 pass, 30 skip Summary no semver update required Finished [ 198.373s] datafusion Building datafusion-expr v54.0.0 (current) Built [ 25.494s] (current) Parsing datafusion-expr v54.0.0 (current) Parsed [ 0.073s] (current) Building datafusion-expr v54.0.0 (baseline) Built [ 25.424s] (baseline) Parsing datafusion-expr v54.0.0 (baseline) Parsed [ 0.074s] (baseline) Checking datafusion-expr v54.0.0 -> v54.0.0 (no change; assume patch) Checked [ 1.161s] 223 checks: 222 pass, 1 fail, 0 warn, 30 skip --- failure constructible_struct_adds_field: externally-constructible struct adds field --- Description: A pub struct constructible with a struct literal has a new pub field. Existing struct literals must be updated to include the new field. ref: https://doc.rust-lang.org/reference/expressions/struct-expr.html impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.48.0/src/lints/constructible_struct_adds_field.ron Failed in: field ScalarFunction.spans in /home/runner/work/datafusion/datafusion/datafusion/expr/src/expr.rs:934 field AggregateFunction.spans in /home/runner/work/datafusion/datafusion/datafusion/expr/src/expr.rs:1109 Summary semver requires new major version: 1 major and 0 minor checks failed Finished [ 54.558s] datafusion-expr Building datafusion-functions v54.0.0 (current) Built [ 29.154s] (current) Parsing datafusion-functions v54.0.0 (current) Parsed [ 0.080s] (current) Building datafusion-functions v54.0.0 (baseline) Built [ 28.746s] (baseline) Parsing datafusion-functions v54.0.0 (baseline) Parsed [ 0.082s] (baseline) Checking datafusion-functions v54.0.0 -> v54.0.0 (no change; assume patch) Checked [ 0.417s] 223 checks: 223 pass, 30 skip Summary no semver update required Finished [ 59.530s] datafusion-functions Building datafusion-functions-aggregate v54.0.0 (current) Built [ 29.621s] (current) Parsing datafusion-functions-aggregate v54.0.0 (current) Parsed [ 0.042s] (current) Building datafusion-functions-aggregate v54.0.0 (baseline) Built [ 29.321s] (baseline) Parsing datafusion-functions-aggregate v54.0.0 (baseline) Parsed [ 0.045s] (baseline) Checking datafusion-functions-aggregate v54.0.0 -> v54.0.0 (no change; assume patch) Checked [ 0.170s] 223 checks: 223 pass, 30 skip Summary no semver update required Finished [ 60.435s] datafusion-functions-aggregate Building datafusion-functions-nested v54.0.0 (current) Built [ 34.225s] (current) Parsing datafusion-functions-nested v54.0.0 (current) Parsed [ 0.035s] (current) Building datafusion-functions-nested v54.0.0 (baseline) Built [ 34.906s] (baseline) Parsing datafusion-functions-nested v54.0.0 (baseline) Parsed [ 0.039s] (baseline) Checking datafusion-functions-nested v54.0.0 -> v54.0.0 (no change; assume patch) Checked [ 0.204s] 223 checks: 223 pass, 30 skip Summary no semver update required Finished [ 70.328s] datafusion-functions-nested Building datafusion-optimizer v54.0.0 (current) Built [ 25.646s] (current) Parsing datafusion-optimizer v54.0.0 (current) Parsed [ 0.028s] (current) Building datafusion-optimizer v54.0.0 (baseline) Built [ 25.651s] (baseline) Parsing datafusion-optimizer v54.0.0 (baseline) Parsed [ 0.031s] (baseline) Checking datafusion-optimizer v54.0.0 -> v54.0.0 (no change; assume patch) Checked [ 0.162s] 223 checks: 223 pass, 30 skip Summary no semver update required Finished [ 52.945s] datafusion-optimizer Building datafusion-physical-expr v54.0.0 (current) Built [ 27.374s] (current) Parsing datafusion-physical-expr v54.0.0 (current) Parsed [ 0.045s] (current) Building datafusion-physical-expr v54.0.0 (baseline) Built [ 27.322s] (baseline) Parsing datafusion-physical-expr v54.0.0 (baseline) Parsed [ 0.047s] (baseline) Checking datafusion-physical-expr v54.0.0 -> v54.0.0 (no change; assume patch) Checked [ 0.349s] 223 checks: 223 pass, 30 skip Summary no semver update required Finished [ 56.239s] datafusion-physical-expr Building datafusion-proto v54.0.0 (current) Built [ 56.353s] (current) Parsing datafusion-proto v54.0.0 (current) Parsed [ 0.017s] (current) Building datafusion-proto v54.0.0 (baseline) Built [ 56.344s] (baseline) Parsing datafusion-proto v54.0.0 (baseline) Parsed [ 0.017s] (baseline) Checking datafusion-proto v54.0.0 -> v54.0.0 (no change; assume patch) Checked [ 0.238s] 223 checks: 223 pass, 30 skip Summary no semver update required Finished [ 114.009s] datafusion-proto Building datafusion-sql v54.0.0 (current) Built [ 39.429s] (current) Parsing datafusion-sql v54.0.0 (current) Parsed [ 0.029s] (current) Building datafusion-sql v54.0.0 (baseline) Built [ 39.892s] (baseline) Parsing datafusion-sql v54.0.0 (baseline) Parsed [ 0.031s] (baseline) Checking datafusion-sql v54.0.0 -> v54.0.0 (no change; assume patch) Checked [ 0.237s] 223 checks: 223 pass, 30 skip Summary no semver update required Finished [ 80.559s] datafusion-sql ``` </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
