gabotechs commented on code in PR #23259:
URL: https://github.com/apache/datafusion/pull/23259#discussion_r3499929738
##########
datafusion/physical-expr/src/partitioning.rs:
##########
@@ -593,11 +600,18 @@ pub enum Distribution {
UnspecifiedDistribution,
/// A single partition is required
SinglePartition,
+ /// Deprecated historical name for [`Distribution::KeyPartitioned`].
+ #[deprecated(since = "54.0.0", note = "Use Distribution::KeyPartitioned")]
Review Comment:
🤔 Shouldn't this say `55.0.0`? because `54.0.0` is already released to
crates.io and it does not show `HashPartitioned` as deprecated.
##########
datafusion/physical-expr/src/partitioning.rs:
##########
@@ -799,43 +825,66 @@ mod tests {
Ok(())
}
+ #[test]
+ #[expect(
+ deprecated,
+ reason = "test intentionally covers deprecated HashPartitioned
compatibility"
+ )]
+ fn deprecated_hash_partitioned_matches_key_partitioned() -> Result<()> {
Review Comment:
For me I think this is fine, but let's see if other contributors suggest
something different
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
