jayzhan211 commented on issue #11359:
URL: https://github.com/apache/datafusion/issues/11359#issuecomment-2271583190
I found `AggregateUDFImpl` is now tightly coupled with `Expr` unlike the
status I got in #10327, thus not possible to eliminate the dependency of
`Expr`. Mainly due to `fn call() -> Expr`
The crate graph is now like
Since we would like to import `PhysicalExpr` for `AggregateUDFImpl`, and
sadly it seems to be tightly coupled with `Expr`.
Therefore, we come out several `common-level` crate, those crate has no
dependencies on `Expr`.
`physical-expr-common` are common things about `physical-expr` concept.
Mainly `PhysicalExpr`, `PhysicalSortExpr`.
Their dependencies are pull out from `expr` to `expr-common`.
`functions-aggregate-common` are more aggregate-specific
Physical expr like Column, Cast, Literal are moved back to physical-expr for
now.
`AggregateFunctionExpr`, `AggregateExprBuilder` are moved to
`physical-expr-functions-aggregate`, they have depdency on `Expr`. It's level
is similar to `physical-expr`, but more aggregate specific.
```mermaid
graph TD;
physical-expr-common --> expr-common;
functions-aggregate-common --> physical-expr-common;
expr --> functions-aggregate-common;
physical-expr-functions-aggregate --> expr;
physical-expr --> expr;
functions-aggregate --> physical-expr;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
