andygrove commented on code in PR #783:
URL: https://github.com/apache/datafusion-comet/pull/783#discussion_r1705886210
##########
native/Cargo.toml:
##########
@@ -39,13 +39,13 @@ arrow-buffer = { version = "52.2.0" }
arrow-data = { version = "52.2.0" }
arrow-schema = { version = "52.2.0" }
parquet = { version = "52.2.0", default-features = false, features =
["experimental"] }
-datafusion-common = { git = "https://github.com/apache/datafusion.git";, rev =
"35c2e7e" }
-datafusion = { default-features = false, git =
"https://github.com/apache/datafusion.git";, rev = "35c2e7e", features =
["unicode_expressions", "crypto_expressions"] }
-datafusion-functions = { git = "https://github.com/apache/datafusion.git";, rev
= "35c2e7e", features = ["crypto_expressions"] }
-datafusion-expr = { git = "https://github.com/apache/datafusion.git";, rev =
"35c2e7e", default-features = false }
-datafusion-physical-plan = { git = "https://github.com/apache/datafusion.git";,
rev = "35c2e7e", default-features = false }
-datafusion-physical-expr-common = { git =
"https://github.com/apache/datafusion.git";, rev = "35c2e7e", default-features =
false }
-datafusion-physical-expr = { git = "https://github.com/apache/datafusion.git";,
rev = "35c2e7e", default-features = false }
+datafusion-common = { git = "https://github.com/apache/datafusion.git";, rev =
"c6f0d3c" }
+datafusion = { default-features = false, git =
"https://github.com/apache/datafusion.git";, rev = "c6f0d3c", features =
["unicode_expressions", "crypto_expressions"] }
+datafusion-functions = { git = "https://github.com/apache/datafusion.git";, rev
= "c6f0d3c", features = ["crypto_expressions"] }
+datafusion-expr = { git = "https://github.com/apache/datafusion.git";, rev =
"c6f0d3c", default-features = false }
+datafusion-physical-plan = { git = "https://github.com/apache/datafusion.git";,
rev = "c6f0d3c", default-features = false }
+datafusion-physical-expr-common = { git =
"https://github.com/apache/datafusion.git";, rev = "c6f0d3c", default-features =
false }
+datafusion-physical-expr = { git = "https://github.com/apache/datafusion.git";,
rev = "c6f0d3c", default-features = false }
Review Comment:
Rather than updating to the latest revision in this PR, let's just update to
the point where min/max were refactored. I think the DataFusion regression is
in a more recent commit.
This worked for me locally.
```suggestion
datafusion-common = { git = "https://github.com/apache/datafusion.git";, rev
= "f4e519f" }
datafusion = { default-features = false, git =
"https://github.com/apache/datafusion.git";, rev = "f4e519f", features =
["unicode_expressions", "crypto_expressions"] }
datafusion-functions = { git = "https://github.com/apache/datafusion.git";,
rev = "f4e519f", features = ["crypto_expressions"] }
datafusion-expr = { git = "https://github.com/apache/datafusion.git";, rev =
"f4e519f", default-features = false }
datafusion-physical-plan = { git =
"https://github.com/apache/datafusion.git";, rev = "f4e519f", default-features =
false }
datafusion-physical-expr-common = { git =
"https://github.com/apache/datafusion.git";, rev = "f4e519f", default-features =
false }
datafusion-physical-expr = { git =
"https://github.com/apache/datafusion.git";, rev = "f4e519f", default-features =
false }
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
