alamb commented on code in PR #23250:
URL: https://github.com/apache/datafusion/pull/23250#discussion_r3501949253
##########
datafusion/physical-plan/src/aggregates/aggregate_hash_table/partial_table.rs:
##########
@@ -62,43 +63,60 @@ impl AggregateHashTable<PartialMarker> {
) -> Result<Option<RecordBatch>> {
let output_schema = Arc::clone(&self.output_schema);
let batch_size = self.batch_size;
- match &mut self.state {
+ // Take ownership of the output state. `emit_next_materialized_batch`
Review Comment:
@2010YOUY01 I think your plan to refactor the aggregate code so it is easier
to work with / understand is already paying off 🙏
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
