github-actions[bot] commented on PR #23201: URL: https://github.com/apache/datafusion/pull/23201#issuecomment-4849900103
<!-- semver-check-comment --> Thank you for opening this pull request! Reviewer note: [cargo-semver-checks](https://github.com/obi1kenobi/cargo-semver-checks) reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). <details> <summary>Details</summary> ``` Cloning apache/main Building datafusion v54.0.0 (current) Built [ 105.680s] (current) Parsing datafusion v54.0.0 (current) Parsed [ 0.036s] (current) Building datafusion v54.0.0 (baseline) Built [ 106.472s] (baseline) Parsing datafusion v54.0.0 (baseline) Parsed [ 0.038s] (baseline) Checking datafusion v54.0.0 -> v54.0.0 (no change; assume patch) Checked [ 0.925s] 223 checks: 223 pass, 30 skip Summary no semver update required Finished [ 215.610s] datafusion Building datafusion-catalog-listing v54.0.0 (current) Built [ 44.669s] (current) Parsing datafusion-catalog-listing v54.0.0 (current) Parsed [ 0.012s] (current) Building datafusion-catalog-listing v54.0.0 (baseline) Built [ 44.596s] (baseline) Parsing datafusion-catalog-listing v54.0.0 (baseline) Parsed [ 0.013s] (baseline) Checking datafusion-catalog-listing v54.0.0 -> v54.0.0 (no change; assume patch) Checked [ 0.114s] 223 checks: 223 pass, 30 skip Summary no semver update required Finished [ 90.721s] datafusion-catalog-listing Building datafusion-common v54.0.0 (current) Built [ 33.199s] (current) Parsing datafusion-common v54.0.0 (current) Parsed [ 0.063s] (current) Building datafusion-common v54.0.0 (baseline) Built [ 32.788s] (baseline) Parsing datafusion-common v54.0.0 (baseline) Parsed [ 0.064s] (baseline) Checking datafusion-common v54.0.0 -> v54.0.0 (no change; assume patch) Checked [ 1.067s] 223 checks: 223 pass, 30 skip Summary no semver update required Finished [ 68.366s] datafusion-common Building datafusion-execution v54.0.0 (current) Built [ 29.814s] (current) Parsing datafusion-execution v54.0.0 (current) Parsed [ 0.025s] (current) Building datafusion-execution v54.0.0 (baseline) Built [ 29.523s] (baseline) Parsing datafusion-execution v54.0.0 (baseline) Parsed [ 0.027s] (baseline) Checking datafusion-execution v54.0.0 -> v54.0.0 (no change; assume patch) Checked [ 0.338s] 223 checks: 221 pass, 2 fail, 0 warn, 30 skip --- failure constructible_struct_adds_field: externally-constructible struct adds field --- Description: A pub struct constructible with a struct literal has a new pub field. Existing struct literals must be updated to include the new field. ref: https://doc.rust-lang.org/reference/expressions/struct-expr.html impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.48.0/src/lints/constructible_struct_adds_field.ron Failed in: field CachedFileMetadata.schema_fingerprint in /home/runner/work/datafusion/datafusion/datafusion/execution/src/cache/cache_manager.rs:101 --- failure method_parameter_count_changed: pub method parameter count changed --- Description: A publicly-visible method now takes a different number of parameters, not counting the receiver (self) parameter. ref: https://doc.rust-lang.org/cargo/reference/semver.html#fn-change-arity impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.48.0/src/lints/method_parameter_count_changed.ron Failed in: datafusion_execution::cache::cache_manager::CachedFileMetadata::new takes 3 parameters in /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/c9172e4be62a775199b80fe7e5713c48fe5593ef/datafusion/execution/src/cache/cache_manager.rs:107, but now takes 4 parameters in /home/runner/work/datafusion/datafusion/datafusion/execution/src/cache/cache_manager.rs:110 datafusion_execution::cache::cache_manager::CachedFileMetadata::is_valid_for takes 1 parameters in /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/c9172e4be62a775199b80fe7e5713c48fe5593ef/datafusion/execution/src/cache/cache_manager.rs:122, but now takes 2 parameters in /home/runner/work/datafusion/datafusion/datafusion/execution/src/cache/cache_manager.rs:127 Summary semver requires new major version: 2 major and 0 minor checks failed Finished [ 60.800s] datafusion-execution ``` </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
