LiaCastaneda commented on PR #23209: URL: https://github.com/apache/datafusion/pull/23209#issuecomment-4853954328
> It looks it is mostly faster but also regresses on some Yes there are a few regressions are there -- There are 36 tpcds queries that run faster (between 5% and 35% faster) and 7 slower ( between 5% - 10% slower) I'm trying to run tpcds SF1 again locally but the results seem very flaky :/ I'm thinking we could try adding a fast-path comparison for cases that compare primitive types and join on a single column, as you suggested -- that may be why some queries regress. I rebased the branch before doing the above. Can we run the `hj` benchmarks? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
