paleolimbot commented on code in PR #23169:
URL: https://github.com/apache/datafusion/pull/23169#discussion_r3507401716
##########
datafusion/physical-expr/src/expressions/cast.rs:
##########
@@ -63,6 +64,10 @@ pub struct CastExpr {
target_field: FieldRef,
/// Cast options
cast_options: CastOptions<'static>,
+ /// Whether to preserve non-extension metadata from the source field.
+ /// When true (default), source metadata is merged with target metadata.
+ /// When false, only the target field's metadata is used.
Review Comment:
This comes from one specific use that is using the physical cast
specifically to strip metadata. I think your later suggestion to remove that
usage (and remove this flag) is a good one (but I'll wait for one more opinion
on what to do here before I commit).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
