andygrove commented on issue #4754: URL: https://github.com/apache/datafusion-comet/issues/4754#issuecomment-4861125004
> I'm the author of Jiff and I'd be happy to answer any questions if you have them! Especially around time zones, I should be able to clarify any points of confusion around the differences between Jiff and `chrono-tz`. They are quite different at the API level (with Jiff not having a `TimeZone` trait), but Jiff's core behavior should be a strict superset of `chrono`. (The most notable thing that Jiff handles in a strictly more flexible way than `chrono` are gaps in civil datetimes when a time zone transition moves from a smaller UTC offset to a bigger UTC offset. i.e., Typically when a region enters daylight saving time.) > > > jiff keeps epoch-day conversion private on purpose (from_unix_epoch_day / to_unix_epoch_day are crate-private). The public idiom is an anchor date plus a day Span: > > It's likely that this will change with a [new `jiff::civil::UnixEpochDay` type](https://github.com/BurntSushi/jiff/issues/595). I imagine this is quite useful if you want to represent dates as 32-bit integers. Without it, I think you have to roll your own math to convert a Gregorian date to a single day number. Jiff really should own that math because it's quite performance critical and easy to get wrong. Thanks @BurntSushi! I appreciate the offer. We'll try and figure things out ourselves, but will definitely ask for help if we hit anything the LLMs can't manage. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
