kosiew commented on code in PR #23299:
URL: https://github.com/apache/datafusion/pull/23299#discussion_r3519732476
##########
datafusion/physical-expr/src/expressions/in_list/primitive_filter.rs:
##########
@@ -425,6 +457,28 @@ mod tests {
assert_contains(&filter, &needles, vec![Some(true), None, None,
Some(true)])
}
+ #[test]
+ fn bitmap_filter_i8_handles_signed_boundaries_and_slices() -> Result<()> {
Review Comment:
Nice coverage here for signed boundary bit-pattern lookups in the direct
`BitmapFilter` tests. One small follow-up idea: it could be useful to add a
public-path regression through `InListExpr::try_new_from_array`, or a SQL-level
test, for `Int8` and `Int16` signed values. That would cover the dispatch path
in `strategy.rs` in addition to the filter implementation itself. Not blocking,
since the current unit tests already exercise the core zero-copy signed bitmap
behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
