zhuqi-lucas commented on code in PR #23288:
URL: https://github.com/apache/datafusion/pull/23288#discussion_r3522680612
##########
datafusion/physical-optimizer/src/ensure_requirements/enforce_sorting/sort_pushdown.rs:
##########
@@ -469,15 +482,15 @@ fn pushdown_requirement_to_children(
}
} else if let Some(aggregate_exec) = plan.downcast_ref::<AggregateExec>() {
handle_aggregate_pushdown(aggregate_exec, parent_required)
+ } else if let Some(projection_exec) =
plan.downcast_ref::<ProjectionExec>() {
+ // A `ProjectionExec` with a fetch is handled in the fetch branch above
Review Comment:
Yeah, remove it — the "handled in fetch branch above" note was informative
at the old short-circuit line (which this PR removes), but here it's noise.
Move the "column-only" rationale into `handle_projection_pushdown`'s doc
comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
