DoumanAsh opened a new issue, #23321: URL: https://github.com/apache/datafusion/issues/23321
### Describe the bug When fetching credentials for S3 object store: https://github.com/apache/datafusion/blob/96a6096c6f4b924e8cab4bc1629759a948e12939/datafusion-cli/src/object_storage.rs#L240 Wrapper does not check [expiration](https://docs.rs/aws-credential-types/1.2.14/aws_credential_types/struct.Credentials.html#method.expiry) to cache these credentials which will result in every request to use potentially heavy provider operation ### To Reproduce _No response_ ### Expected behavior _No response_ ### Additional context This is a not big deal as I believe majority of credentials will be static. Nevertheless addition of `sso` feature on `aws-config` would result in many HTTP requests with such implementation (potentially leading to rate limit errors) I'm not sure if other sources of auth will result in HTTP request spam So JFYI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
