Rich-T-kid commented on code in PR #23344:
URL: https://github.com/apache/datafusion/pull/23344#discussion_r3531648335
##########
datafusion/physical-plan/src/aggregates/group_values/multi_group_by/mod.rs:
##########
@@ -1076,6 +1089,35 @@ fn make_group_column(field: &Field) -> Result<Box<dyn
GroupColumn>> {
);
Ok(v.into_iter().next().unwrap())
}
+/// Returns a comparison cost tier for `data_type` (1 = cheapest, 5 = most
expensive).
+/// Used to order columns in [`GroupValuesColumn::compare_order`] so cheap
comparisons
+/// eliminate rows before expensive ones are evaluated.
+/// see <https://github.com/apache/datafusion/issues/23342>
+fn compare_tier(data_type: &DataType) -> u8 {
Review Comment:
Im honestly not too familiar with the join operator logic. but presumably
the same concepts should apply there. Ideally i'd like to move forward with
#23342. but I can make a follow up ticket to move this into a higher modules
for code re-use
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
