saadtajwar opened a new pull request, #23349: URL: https://github.com/apache/datafusion/pull/23349
## Which issue does this PR close? - Closes #22867 ## Rationale for this change DFHeapSize depends on a critical invariant: shared heap allocations must be counted once per traversal context. If Arc implementations drift, memory accounting becomes inconsistent and hard to reason about. Consolidating the one-time-accounting logic improves: Correctness durability (single source of truth for Arc dedup behavior) Maintainability (less repeated logic) Reviewability (future changes touch one helper) ## What changes are included in this PR? Helper functions for `Arc` allocation identity and deduplication, namely for providing pointer extraction & `DFHeapSizeCtx` set membership checks, with the `DFHeapSize` implementations on `Arc` backed types using the new helpers ## Are these changes tested? Yes, the below are passing: ``` cargo test -p datafusion-common heap_size --lib cargo test -p datafusion-common --doc heap_size ``` ## Are there any user-facing changes? No -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
