andygrove commented on code in PR #4791:
URL: https://github.com/apache/datafusion-comet/pull/4791#discussion_r3532528929
##########
spark/src/test/scala/org/apache/comet/exec/CometAggregateSuite.scala:
##########
@@ -2150,4 +2159,112 @@ class CometAggregateSuite extends CometTestBase with
AdaptiveSparkPlanHelper {
}
}
+ // The test to reproduce `offset overflow` for aggregation queries, when
interim data
+ // get exploded 100x comparing to initial input size.
+ // It is not supposed to run on CI as the test requires significant RAM to
succeed
+ ignore("CUBE(9) + COUNT(DISTINCT) wide Utf8 keys: useLargeDataTypes
preserves correctness") {
Review Comment:
I don't see any new tests for the functional changes in this PR. Could you
add functional tests that use small amounts of data, just to test for
correctness?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
