wForget commented on PR #4779: URL: https://github.com/apache/datafusion-comet/pull/4779#issuecomment-4899166363
Since `external_shuffle` only needs to use the repartitioner through `Box<dyn ShufflePartitioner>`, we can pass different `PartitionWriter` implementations when constructing the `ShufflePartitioner` and simply return a `Result<Box<dyn ShufflePartitioner>>`. I have also done some implementation work for Uniffle RSS, and with that approach the native code compiles successfully: https://github.com/wForget/arrow-datafusion-comet/blob/ff68265277d12c5600b450a4cc67073791062490/native/shuffle/src/shuffle_writer.rs#L212-L272 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
