alamb commented on code in PR #23372: URL: https://github.com/apache/datafusion/pull/23372#discussion_r3536131421
########## datafusion/physical-plan/src/aggregates/aggregate_stream.rs: ########## Review Comment: I actually think no_grouping.rs is a clearer module name, but the stream name is `AggregateStream` I considered renaming the stream to `NoGroupingAggregateStream` and then `no_grouping_stream.rs` but that seemed like maybe too complicated -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
