Rich-T-kid commented on code in PR #23187: URL: https://github.com/apache/datafusion/pull/23187#discussion_r3538478939
########## datafusion/physical-plan/src/aggregates/group_values/multi_group_by/dictionary.rs: ########## @@ -0,0 +1,401 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +use crate::aggregates::group_values::multi_group_by::GroupColumn; +use arrow::array::{ + Array, ArrayRef, AsArray, BooleanBufferBuilder, DictionaryArray, PrimitiveArray, +}; +use arrow::compute::concat; +use arrow::datatypes::{ArrowDictionaryKeyType, ArrowNativeType, DataType, Field}; +use datafusion_common::Result; +use hashbrown::HashMap; +use std::marker::PhantomData; +use std::sync::{Arc, Mutex}; + +/// Use the cache path in `vectorized_equal_to` only when the number of unique lhs group IDs +/// is at most this fraction of the total comparisons (1/10 = 10%). +const CACHE_USE_THRESHOLD: usize = 10; + +pub struct DictionaryGroupValuesColumn<K: ArrowDictionaryKeyType + Send + Sync> { + inner: Box<dyn GroupColumn>, + null_array: ArrayRef, + // Mutex is required because `vectorized_equal_to` takes `&self` (GroupColumn trait Review Comment: RefCell doesn't work here because its not sync -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
