alamb commented on code in PR #23315:
URL: https://github.com/apache/datafusion/pull/23315#discussion_r3539324289
##########
benchmarks/README.md:
##########
@@ -496,6 +496,49 @@ The ClickBench[1] benchmarks are widely cited in the
industry and
focus on grouping / aggregation / filtering. This runner uses the
scripts and queries from [2].
+The runner applies two ClickBench-specific setup steps automatically:
+
+- ClickBench stores `EventDate` as `UInt16` days since `1970-01-01`.
+ The runner registers the parquet data as `hits_raw`, then creates a
+ `hits` view that casts `EventDate` through `INTEGER` to `DATE` for the
+ benchmark queries.
+- The source partitioned ClickBench dataset stores string columns without
+ the `string` Parquet logical type annotation. For partitioned runs, the
+ runner enables the parquet `binary_as_string` option so those columns
+ are read as strings.
+
+If you set up ClickBench manually through SQL, use the same `EventDate`
+view pattern:
+
+```sql
+CREATE EXTERNAL TABLE hits_raw
+STORED AS PARQUET
+LOCATION 'benchmarks/data/hits.parquet';
+
+CREATE VIEW hits AS
+SELECT * EXCEPT ("EventDate"),
+ CAST(CAST("EventDate" AS INTEGER) AS DATE) AS "EventDate"
+FROM hits_raw;
+```
+
+For the partitioned dataset, use `benchmarks/data/hits_partitioned` and
Review Comment:
It would also help (maybe as a follow on PR) to give an explicit example of
the SQL required for `hits_partitioned`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
