comphead commented on PR #4850: URL: https://github.com/apache/datafusion-comet/pull/4850#issuecomment-4910168822
The Spark checks Spark result against HiveQL, compares the string by string, no way we can insert something like `checkSparkAnswerWithTol`. the golden file looks like that `src/test/resources/golden/windowing.q -- 5. testCountWithWindowingUDAF-0-3bde93728761b780a745c2ce0398aa0f` The comparison is line by line `org/apache/spark/sql/hive/execution/HiveComparisonTest.scala:371` So I'm not sure if this hive WF actually needed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
