gene-bordegaray commented on code in PR #23184:
URL: https://github.com/apache/datafusion/pull/23184#discussion_r3540506004
##########
datafusion/physical-optimizer/src/ensure_requirements/enforce_distribution.rs:
##########
@@ -946,6 +947,14 @@ struct RepartitionRequirementStatus {
hash_necessary: bool,
}
+/// Per-child state while enforcing a parent's distribution requirements.
+struct DistributionChildState {
Review Comment:
I decided to revert the name changes and smaller changes I made to this file
as clean up and introduced the minimal but clean new logic needed for this
behavior
I think it is better to just accept this rule isn't pretty right now and
rather than small refactors as we work through PRs dedeicate an effort just to
refactoring this logic
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
